Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates FluentUI dependencies to 4.11.9, refactors icon resolution to use the new TryGetInstance pattern, and removes the temporary FixedFluentCombobox workaround in favor of the built-in component.
- Bump
Microsoft.FluentUI.AspNetCore.Componentsand.Iconsto 4.11.9 - Replace try/catch in
IconResolverwithIconInfo.TryGetInstance - Delete
FixedFluentComboboxcomponent and switch references toFluentCombobox
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Aspire.Dashboard/Model/IconResolver.cs | Refactored to use TryGetInstance instead of catch‐all logic |
| src/Aspire.Dashboard/Components/Dialogs/FilterDialog.razor | Switched from FixedFluentCombobox to built-in FluentCombobox |
| src/Aspire.Dashboard/Components/Controls/FixedFluentCombobox.* | Removed temporary workaround component files |
| Directory.Packages.props | Bumped FluentUI package versions to 4.11.9 |
Comments suppressed due to low confidence (2)
src/Aspire.Dashboard/Model/IconResolver.cs:45
- [nitpick] The method takes both
IconKey key(which includesDesiredIconSize) and a separatesizeparameter. Consider removing the redundantsizeargument and usingkey.DesiredIconSizeto reduce duplication and potential mismatch.
private static bool TryGetIcon(IconKey key, IconSize size, [NotNullWhen(true)] out CustomIcon? icon)
src/Aspire.Dashboard/Model/IconResolver.cs:54
- Add a unit test for the failure path when
TryGetInstancereturns false to ensure coverage for missing icons and proper null handling.
return iconInfo.TryGetInstance(out icon);
danmoseley
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
<remarks />and<code />elements on your triple slash comments?doc-ideatemplatebreaking-changetemplatediagnostictemplate